On Tue, Aug 01, 2023 at 02:39:49PM +0800, Yinbo Zhu wrote: > > > 在 2023/7/31 下午11:55, Conor Dooley 写道: > > On Mon, Jul 31, 2023 at 05:10:58PM +0800, Yinbo Zhu wrote: > > > Add parsing GPIO configure, input, output, interrupt register offset > > > address and GPIO control mode support. > > > > This reeks of insufficient use of SoC specific compatibles. Do GPIO > > controllers on the same SoC have different register offsets? > > > Yes, > > > Where are the users for this? > > > For example, ls2k500 contains multiple GPIO chips with different > (configure, input, output, interrupt) offset addresses, but all others > are the same. Right. That's admittedly not what I expected to hear! Can you firstly explain this in the commit message, and secondly add a soc-specific compatible for the ls2k500 and only allow these properties on that SoC? Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature
