Hi Randy, Thanks for reviewing, On Mon, Jul 31, 2023 at 3:02 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > > > > On 7/31/23 10:46, David Dai wrote: > > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > > index f429b9b37b76..3977ca796747 100644 > > --- a/drivers/cpufreq/Kconfig > > +++ b/drivers/cpufreq/Kconfig > > @@ -217,6 +217,21 @@ config CPUFREQ_DT > > > > If in doubt, say N. > > > > +config CPUFREQ_VIRT > > + tristate "Virtual cpufreq driver" > > + depends on OF > > + select PM_OPP > > + help > > The 4 lines above should be indented with one tab (not 8 spaces). Ok. > > > + This adds a virtualized cpufreq driver for guest kernels that > > + read/writes to a MMIO region for a virtualized cpufreq device to > > reads/writes to an MMIO region Will fix these, thanks! David > > > + communicate with the host. It sends frequency updates to the host > > + which gets used as a hint to schedule vCPU threads and select CPU > > + frequency. If a VM does not support a virtualized FIE such as AMUs, > > + it updates the frequency scaling factor by polling host CPU frequency > > + to enable accurate Per-Entity Load Tracking for tasks running in the guest. > > + > > + If in doubt, say N. > > -- > ~Randy