On Fri, 28 Jul 2023 21:20:13 +0200, Stanislav Jakubek wrote: > Convert Broadcom Kona family GPIO controller bindings to DT schema. > > Changes during conversion: > - add used, but previously undocumented SoC-specific compatibles > > Signed-off-by: Stanislav Jakubek <stano.jakubek@xxxxxxxxx> > --- > RFC since dt_binding_check is giving me these errors/warnings: > > Documentation/devicetree/bindings/gpio/brcm,kona-gpio.example.dts:21.23-34.11: Warning (interrupts_property): /example-0/gpio@35003000: Missing interrupt-parent > > The old txt bindings and all current DTs do not use interrupt-parent AFAICT, > so I'm not sure what to do about that. > > Documentation/devicetree/bindings/gpio/brcm,kona-gpio.example.dtb: gpio@35003000: interrupts: [[0], [106], [4], [0], [115], [4], [0], [114], [4], [0], [113], [4], [0], [112], [4], [0], [111], [4]] is too long > > Here I'm not even sure what the issue is. > > .../bindings/gpio/brcm,kona-gpio.txt | 52 ------------- > .../bindings/gpio/brcm,kona-gpio.yaml | 77 +++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 78 insertions(+), 53 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/gpio/brcm,kona-gpio.txt > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,kona-gpio.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/gpio/brcm,kona-gpio.example.dts:21.23-34.11: Warning (interrupts_property): /example-0/gpio@35003000: Missing interrupt-parent /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/gpio/brcm,kona-gpio.example.dtb: gpio@35003000: interrupts: [[0], [106], [4], [0], [115], [4], [0], [114], [4], [0], [113], [4], [0], [112], [4], [0], [111], [4]] is too long from schema $id: http://devicetree.org/schemas/gpio/brcm,kona-gpio.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ZMQU7ap9CxfY5eIu@standask-GA-A55M-S2HP The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
