On 28/07/2023 11:08, Maso Huang wrote: > Add document for mt7986 board with wm8960. > > Signed-off-by: Maso Huang <maso.huang@xxxxxxxxxxxx> > --- > .../sound/mediatek,mt7986-wm8960.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml > new file mode 100644 > index 000000000000..76394f7e5502 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mediatek,mt7986-wm8960.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT7986 sound card with WM8960 codec > + > +maintainers: > + - Maso Huang <maso.huang@xxxxxxxxxxxx> > + > +properties: > + compatible: > + const: mediatek,mt7986-wm8960-machine > + > + mediatek,platform: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of MT7986 platform. > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: > + A list of the connections between audio components. Each entry is a > + sink/source pair of strings. Valid names could be the input or output > + widgets of audio components, power supplies, MicBias of codec and the > + software switch. > + > + mediatek,audio-codec: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of wm8960 codec. > + How did you implement Rob's comment? Or did you just ignore it? Best regards, Krzysztof