Re: [PATCH 2/2] media: i2c: imx519: Support for the Sony IMX519 sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/28/23 12:56 PM, kernel test robot wrote:
Hi Umang,

kernel test robot noticed the following build errors:

[auto build test ERROR on media-tree/master]
[also build test ERROR on soc/for-next linus/master v6.5-rc3 next-20230727]
[cannot apply to sailus-media-tree/streams]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Umang-Jain/media-dt-bindings-imx519-Add-IMX519-DT-bindings/20230727-234440
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20230727154108.308320-3-umang.jain%40ideasonboard.com
patch subject: [PATCH 2/2] media: i2c: imx519: Support for the Sony IMX519 sensor
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230728/202307281538.bqZ5kcV9-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230728/202307281538.bqZ5kcV9-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307281538.bqZ5kcV9-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

    drivers/media/i2c/imx519.c: In function 'imx519_open':
drivers/media/i2c/imx519.c:1170:30: error: 'MEDIA_BUS_FMT_SENSOR_DATA' undeclared (first use in this function)

This comes from the bcm2835-unicam for Rpi's that's being worked upon. And I was testing this driver on top of it.
     1170 |         try_fmt_meta->code = MEDIA_BUS_FMT_SENSOR_DATA;
          |                              ^~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/media/i2c/imx519.c:1170:30: note: each undeclared identifier is reported only once for each function it appears in
    drivers/media/i2c/imx519.c: In function 'imx519_enum_mbus_code':
    drivers/media/i2c/imx519.c:1319:30: error: 'MEDIA_BUS_FMT_SENSOR_DATA' undeclared (first use in this function)
     1319 |                 code->code = MEDIA_BUS_FMT_SENSOR_DATA;
          |                              ^~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/media/i2c/imx519.c: In function 'imx519_enum_frame_size':
    drivers/media/i2c/imx519.c:1346:34: error: 'MEDIA_BUS_FMT_SENSOR_DATA' undeclared (first use in this function)
     1346 |                 if (fse->code != MEDIA_BUS_FMT_SENSOR_DATA || fse->index > 0)
          |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/media/i2c/imx519.c: In function 'imx519_update_metadata_pad_format':
    drivers/media/i2c/imx519.c:1382:28: error: 'MEDIA_BUS_FMT_SENSOR_DATA' undeclared (first use in this function)
     1382 |         fmt->format.code = MEDIA_BUS_FMT_SENSOR_DATA;
          |                            ^~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/media/i2c/imx519.c: In function 'imx519_get_pad_format':
    drivers/media/i2c/imx519.c:1404:33: error: 'MEDIA_BUS_FMT_SENSOR_DATA' undeclared (first use in this function)
     1404 |                                 MEDIA_BUS_FMT_SENSOR_DATA;
          |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/MEDIA_BUS_FMT_SENSOR_DATA +1170 drivers/media/i2c/imx519.c

   1149	
   1150	static int imx519_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
   1151	{
   1152		struct imx519 *imx519 = to_imx519(sd);
   1153		struct v4l2_mbus_framefmt *try_fmt_img =
   1154			v4l2_subdev_get_try_format(sd, fh->state, IMAGE_PAD);
   1155		struct v4l2_mbus_framefmt *try_fmt_meta =
   1156			v4l2_subdev_get_try_format(sd, fh->state, METADATA_PAD);
   1157		struct v4l2_rect *try_crop;
   1158	
   1159		mutex_lock(&imx519->mutex);
   1160	
   1161		/* Initialize try_fmt for the image pad */
   1162		try_fmt_img->width = supported_modes_10bit[0].width;
   1163		try_fmt_img->height = supported_modes_10bit[0].height;
   1164		try_fmt_img->code = imx519_get_format_code(imx519);
   1165		try_fmt_img->field = V4L2_FIELD_NONE;
   1166	
   1167		/* Initialize try_fmt for the embedded metadata pad */
   1168		try_fmt_meta->width = IMX519_EMBEDDED_LINE_WIDTH;
   1169		try_fmt_meta->height = IMX519_NUM_EMBEDDED_LINES;
1170		try_fmt_meta->code = MEDIA_BUS_FMT_SENSOR_DATA;
   1171		try_fmt_meta->field = V4L2_FIELD_NONE;
   1172	
   1173		/* Initialize try_crop */
   1174		try_crop = v4l2_subdev_get_try_crop(sd, fh->state, IMAGE_PAD);
   1175		try_crop->left = IMX519_PIXEL_ARRAY_LEFT;
   1176		try_crop->top = IMX519_PIXEL_ARRAY_TOP;
   1177		try_crop->width = IMX519_PIXEL_ARRAY_WIDTH;
   1178		try_crop->height = IMX519_PIXEL_ARRAY_HEIGHT;
   1179	
   1180		mutex_unlock(&imx519->mutex);
   1181	
   1182		return 0;
   1183	}
   1184	





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux