On 27/07/2023 12:23, Antoniu Miclaus wrote: > Add bindings for the VCC regulators of the ADMV1013 microware > upconverter. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> Subject: missing spaces between prefix parts. > --- > .../bindings/iio/frequency/adi,admv1013.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > index fc813bcb6532..6660299ac1ad 100644 > --- a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > @@ -39,6 +39,46 @@ properties: > description: > Analog voltage regulator. > > + vcc-drv-supply: > + description: > + RF Driver voltage regulator. > + > + vcc2-drv-supply: > + description: > + RF predriver voltage regulator. > + > + vcc-vva-supply: > + description: > + VVA Control Circuit voltage regulator. > + > + vcc-amp1-supply: > + description: > + RF Amplifier 1 voltage regulator. > + > + vcc-amp2-supply: > + description: > + RF Amplifier 2 voltage regulator. > + > + vcc-env-supply: > + description: > + Envelope Detector voltage regulator. > + > + vcc-bg-supply: > + description: > + Mixer Chip Band Gap Circuit voltage regulator. > + > + vcc-bg2-supply: > + description: > + VGA Chip Band Gap Circuit voltage regulator. > + > + vcc-mixer-supply: > + description: > + Mixer voltage regulator. > + > + vcc-quad-supply: > + description: > + Quadruppler voltage regulator. > + You made them required in the driver, so they should be required here as well. They should be required anyway, because AFAIU they have to be provided. OTOH, this will break the ABI, so your driver might need to take them as optional. Best regards, Krzysztof
