Hi Conor, On Thu, 27 Jul 2023 10:53:15 +0100 Conor Dooley <conor@xxxxxxxxxx> wrote: > On Thu, Jul 27, 2023 at 11:09:48AM +0200, Herve Codina wrote: > > On Thu, 27 Jul 2023 09:19:59 +0100 > > Conor Dooley <conor@xxxxxxxxxx> wrote: > > > On Wed, Jul 26, 2023 at 05:02:01PM +0200, Herve Codina wrote: > > > If needed, I can change to: > > title: QMC (QUICC Multichannel Controller) HDLC > > Let me known if it is better to you. > > If it were me writing the binding, I'd probably use something like > "Freescale/NXP QUICC Multichannel Controller (QMC) HDLC", but it is not > a big deal, I just had a "wtf is this" moment :) I will change to "Freescale/NXP QUICC Multichannel Controller (QMC) HDLC" in the next iteration. > > > > > > > + fsl,qmc-chan: > > > > > > Perhaps I am just showing my lack of knowledge in this area, but what is > > > fsl specific about wanting a reference to the channel of a "QMC"? > > > Is this something that hardware from other manufacturers would not also > > > want to do? > > > > The QMC and the QMC channel are something specific to the SoC. This IP is only > > available on some Freescale/NXP SoCs. > > > > When I upstreamed the 'fsl,qmc-audio.yaml', I first used a generic name for this > > property and Kristoff asked to change to a vendor prefixed name. > > https://lore.kernel.org/linux-kernel/1dfade07-f8c4-2e16-00dc-c7d183708259@xxxxxxxxxx/ > > > > Based on this, as the property 'fsl,qmc-chan' has the exact same meaning in > > fsl,qmc-audio.yaml and fsl,qmc-hdlc.yaml, I use the same name. > > Okay, thanks for explaining! You're welcome. Regards, Hervé
