Patches 1, 2, 3, and 4 have a typo in the Subject: s/AMR/ARM. On Wed, Jul 26, 2023 at 4:03 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > Fixed regulators put under "regulators" node will not be populated, > unless simple-bus or something similar is used. Drop the "regulators" > wrapper node to fix this. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- > arch/arm/boot/dts/nxp/mxs/imx28-m28evk.dts | 45 ++++++++++------------ > 1 file changed, 20 insertions(+), 25 deletions(-) > > diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-m28evk.dts b/arch/arm/boot/dts/nxp/mxs/imx28-m28evk.dts > index e350d57a4cec..6bf26f386a5e 100644 > --- a/arch/arm/boot/dts/nxp/mxs/imx28-m28evk.dts > +++ b/arch/arm/boot/dts/nxp/mxs/imx28-m28evk.dts > @@ -18,33 +18,28 @@ backlight { > default-brightness-level = <6>; > }; > > - regulators { > - reg_vddio_sd0: regulator@1 { > - compatible = "regulator-fixed"; > - reg = <1>; > - regulator-name = "vddio-sd0"; > - regulator-min-microvolt = <3300000>; > - regulator-max-microvolt = <3300000>; > - gpio = <&gpio3 28 0>; > - }; > + reg_vddio_sd0: regulator-1 { It should be better to write: reg_vddio_sd0: regulator-vddio-sd0 { regulator-1 is not very descriptive.