RE: [PATCH 1/1] arm64: dts: imx93: Fix LPUART compatible list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> Sent: 2023年7月26日 19:11
> To: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer
> <s.hauer@xxxxxxxxxxxxxx>; Fabio Estevam <festevam@xxxxxxxxx>; Peng
> Fan <peng.fan@xxxxxxx>
> Cc: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>; Pengutronix Kernel
> Team <kernel@xxxxxxxxxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH 1/1] arm64: dts: imx93: Fix LPUART compatible list
> 
> The compatible list for imx93 LPUART does not include imx8ulp-lpuart variant.
> Drop it according to bindings.

Hi Alexander, no, imx93 should include the imx8ulp-lpuart compatible, please update your dt bindings.
https://lore.kernel.org/all/20230705015602.29569-4-sherry.sun@xxxxxxx/
This patch now in the tty git tree (tty-next branch).

Best Regards
Sherry

> 
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---
> This fixes warnings like:
> arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dtb:
> serial@44390000: compatible: 'oneOf' conditional failed, one must be fixed:
>         ['fsl,imx93-lpuart', 'fsl,imx8ulp-lpuart', 'fsl,imx7ulp-lpuart'] is too long
>         'fsl,imx93-lpuart' is not one of ['fsl,vf610-lpuart', 'fsl,ls1021a-lpuart',
> 'fsl,ls1028a-lpuart', 'fsl,imx7ulp-lpuart', 'fsl,imx8qxp-lpuart', 'fsl,imxrt1050-
> lpuart']
>         'fsl,imx93-lpuart' is not one of ['fsl,imx8qm-lpuart', 'fsl,imx8dxl-lpuart']
>         'fsl,imxrt1050-lpuart' was expected
>         'fsl,imx7ulp-lpuart' was expected
>         'fsl,imx8qxp-lpuart' was expected
>         'fsl,imxrt1170-lpuart' was expected
>         from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicet
> ree.org%2Fschemas%2Fserial%2Ffsl-
> lpuart.yaml%23&data=05%7C01%7Csherry.sun%40nxp.com%7C80432b48b2
> d848c100e908db8dc902a2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7
> C0%7C638259666697434989%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w
> LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> %7C%7C&sdata=mHorQA%2BLsCoGhPtd8SqV%2B45xT1irTLkI6qKCKcqc4BI%3
> D&reserved=0
> arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dtb:
> serial@44390000: Unevaluated properties are not allowed ('compatible' was
> unexpected)
>         from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicet
> ree.org%2Fschemas%2Fserial%2Ffsl-
> lpuart.yaml%23&data=05%7C01%7Csherry.sun%40nxp.com%7C80432b48b2
> d848c100e908db8dc902a2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7
> C0%7C638259666697434989%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w
> LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> %7C%7C&sdata=mHorQA%2BLsCoGhPtd8SqV%2B45xT1irTLkI6qKCKcqc4BI%3
> D&reserved=0
> 
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 4ec9df78f2050..5ba92c9be78ba 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -291,7 +291,7 @@ lpspi2: spi@44370000 {
>  			};
> 
>  			lpuart1: serial@44380000 {
> -				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-
> lpuart", "fsl,imx7ulp-lpuart";
> +				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-
> lpuart";
>  				reg = <0x44380000 0x1000>;
>  				interrupts = <GIC_SPI 19
> IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART1_GATE>;
> @@ -300,7 +300,7 @@ lpuart1: serial@44380000 {
>  			};
> 
>  			lpuart2: serial@44390000 {
> -				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-
> lpuart", "fsl,imx7ulp-lpuart";
> +				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-
> lpuart";
>  				reg = <0x44390000 0x1000>;
>  				interrupts = <GIC_SPI 20
> IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART2_GATE>;
> @@ -545,7 +545,7 @@ lpspi4: spi@42560000 {
>  			};
> 
>  			lpuart3: serial@42570000 {
> -				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-
> lpuart", "fsl,imx7ulp-lpuart";
> +				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-
> lpuart";
>  				reg = <0x42570000 0x1000>;
>  				interrupts = <GIC_SPI 68
> IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART3_GATE>;
> @@ -554,7 +554,7 @@ lpuart3: serial@42570000 {
>  			};
> 
>  			lpuart4: serial@42580000 {
> -				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-
> lpuart", "fsl,imx7ulp-lpuart";
> +				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-
> lpuart";
>  				reg = <0x42580000 0x1000>;
>  				interrupts = <GIC_SPI 69
> IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART4_GATE>;
> @@ -563,7 +563,7 @@ lpuart4: serial@42580000 {
>  			};
> 
>  			lpuart5: serial@42590000 {
> -				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-
> lpuart", "fsl,imx7ulp-lpuart";
> +				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-
> lpuart";
>  				reg = <0x42590000 0x1000>;
>  				interrupts = <GIC_SPI 70
> IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART5_GATE>;
> @@ -572,7 +572,7 @@ lpuart5: serial@42590000 {
>  			};
> 
>  			lpuart6: serial@425a0000 {
> -				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-
> lpuart", "fsl,imx7ulp-lpuart";
> +				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-
> lpuart";
>  				reg = <0x425a0000 0x1000>;
>  				interrupts = <GIC_SPI 71
> IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART6_GATE>;
> @@ -610,7 +610,7 @@ flexspi1: spi@425e0000 {
>  			};
> 
>  			lpuart7: serial@42690000 {
> -				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-
> lpuart", "fsl,imx7ulp-lpuart";
> +				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-
> lpuart";
>  				reg = <0x42690000 0x1000>;
>  				interrupts = <GIC_SPI 210
> IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART7_GATE>;
> @@ -619,7 +619,7 @@ lpuart7: serial@42690000 {
>  			};
> 
>  			lpuart8: serial@426a0000 {
> -				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-
> lpuart", "fsl,imx7ulp-lpuart";
> +				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-
> lpuart";
>  				reg = <0x426a0000 0x1000>;
>  				interrupts = <GIC_SPI 211
> IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART8_GATE>;
> --
> 2.34.1





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux