On Sat, Jul 22, 2023 at 11:27:21AM +0200, Krzysztof Kozlowski wrote: > On 21/07/2023 22:37, Duje Mihanović wrote: > > Add dt bindings and documentation for Marvell PXA1908 SoC. > > > > Signed-off-by: Duje Mihanović <duje.mihanovic@xxxxxxxx> > > --- > > .../bindings/arm/marvell/marvell,pxa1908.yaml | 33 +++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml b/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml > > new file mode 100644 > > index 000000000000..085d238129ad > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml > > I suggest having one bindings file for all pxa platforms, not per one SoC. Or perhaps mirroring the new dts directory structure. PXA is really multiple families. This one is more aligned with MMP than the PXA2xx/3xx. Rob