On 21/07/2023 22:37, Duje Mihanović wrote: > Add dt bindings and documentation for Marvell PXA1908 SoC. > > Signed-off-by: Duje Mihanović <duje.mihanovic@xxxxxxxx> > --- > .../bindings/arm/marvell/marvell,pxa1908.yaml | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml > > diff --git a/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml b/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml > new file mode 100644 > index 000000000000..085d238129ad > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/marvell/marvell,pxa1908.yaml I suggest having one bindings file for all pxa platforms, not per one SoC. > @@ -0,0 +1,33 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/marvell/pxa1908.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell PXA1908 Platforms > + > +maintainers: > + - Duje Mihanović <duje.mihanovic@xxxxxxxx> > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - items: > + - enum: > + - samsung,coreprimevelte > + - const: marvell,pxa1908 > + > + pxa,rev-id: Incorrect vendor prefix > + $ref: /schemas/types.yaml#/definitions/uint32-array > + oneOf: That's not oneOf, so just items: > + - items: > + - description: Board ID > + - description: Board revision > + description: | Best regards, Krzysztof
