On Mon, Jul 17, 2023 at 9:25 AM Huqiang Qin <huqiang.qin@xxxxxxxxxxx> wrote: > > Andy had more comments about the header inclusion. Please > > include all used headers directly as requested, I think it's a good > > idea and avoids confusing compile problems. > > Yes, this is a good idea, but when many files must include the same batch > of header files (seems to have become a kind of template), it seems like > a good choice for us to put them all in pinctrl-meson.h (actually been doing > this a long time ago). OK I'd say that is up to the taste of the driver maintainer so it's OK. Yours, Linus Walleij