Hi Huqiang, thanks for your patch! On Fri, Jul 14, 2023 at 2:25 PM Huqiang Qin <huqiang.qin@xxxxxxxxxxx> wrote: > Add a new pinctrl driver for Amlogic C3 SoCs which share > the same register layout as the previous Amloigc S4. How is the spelling of amlogic there in the end. > Signed-off-by: Huqiang Qin <huqiang.qin@xxxxxxxxxxx> > --- > > V1 -> V2: > Added a comma to the last item of the array and a period to > the commit message. Andy had more comments about the header inclusion. Please include all used headers directly as requested, I think it's a good idea and avoids confusing compile problems. Yours, Linus Walleij
