On 7/21/2023 6:55 AM, Oleksij Rempel wrote:
KSZ switches with WoL support signals wake event over PME pin. If this pin is attached to some external PMIC or System Controller can't be described as GPIO, the only way to describe it in the devicetree is to use wakeup-source property.
There is a word missing in the above sentence between "System Controller" and "can't be", and I believe the word is "that".
So, add support for this property and enable PME switch output if this property is present.
A property that "enables" something means that you are using Device Tree as a way to encode some sort of policy, maybe this is just the wording here and what you would want to say is that describing the node with a 'wakeup-source' property indicates that the device is wake-up capable, regardless of the presence/absence of an interrupt parent?
With the commit message reworded: Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> -- Florian
