On Fri, Jul 21, 2023 at 05:05:51AM -0600, James Hilliard wrote: > On Fri, Jul 21, 2023 at 4:43 AM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 21/07/2023 12:33, James Hilliard wrote: > > > + compatible = "regulator-fixed"; > > > + regulator-name = "touch_3v3_supply"; > > > + regulator-always-on; > > > > Also, missing constraints. > > Hmm, what's the correct way to determine the constraint values? You should know/understand the hardware design. Normally when writing a DT file you have the hardware schematics and the relevant datasheets available. > I'm guessing they should just be set to this based on the name?: > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; This looks like a good guess, assuming that the regulator name is correct. Francesco
