On Fri, Jul 21, 2023 at 4:43 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 21/07/2023 12:33, James Hilliard wrote: > > This patch adds support for the Variscite VAR_SOM-MX6 SoM with : > > - i.MX6 Quad or Dual Lite SoC > > - 256 – 4096 MB DDR3 > > - 4-64 GB eMMC > > - 128 – 1024 MB SLC NAND > > - Camera Interface > > - HDMI+CEC interface > > - LVDS / DSI / Parallel RGB interfaces > > - Ethernet RGMII interface > > - On-SoM Wi-Fi/Bluetooth with WiLink wl183x SDIO Module > > - SD/MMC/SDIO interface > > - USB Host + USB OTG interface > > - I2C interfaces > > - SPI interfaces > > - PCI-Express 2.0 interface > > - on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface > > - Digital Audio interface > > - S/PDIF interface > > > > Product website : https://www.variscite.com/product/system-on-module-som/cortex-a9/var-som-mx6-cpu-freescale-imx6/ > > > > Support is handled with a SoM-centric dtsi exporting the default interfaces > > along the default pinmuxing to be enabled by the board dts file. > > > > This file is based on the one provided by Variscite on their own > > kernel, but adapted for mainline. > > > > Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> > > Signed-off-by: James Hilliard <james.hilliard1@xxxxxxxxx> > > --- > > .../arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi | 544 ++++++++++++++++++ > > 1 file changed, 544 insertions(+) > > create mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi > > > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi > > new file mode 100644 > > index 000000000000..a7d2aecd83fe > > --- /dev/null > > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi > > @@ -0,0 +1,544 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Support for Variscite VAR-SOM-MX6 Module > > + * > > + * Copyright 2011 Linaro Ltd. > > + * Copyright 2012 Freescale Semiconductor, Inc. > > + * Copyright (C) 2014-2016 Variscite, Ltd. > > + * Author: Donio Ron <ron.d@xxxxxxxxxxxxx> > > + * Copyright 2022 Bootlin > > + */ > > + > > +/dts-v1/; > > + > > +#include "imx6q.dtsi" > > +#include <dt-bindings/clock/imx6qdl-clock.h> > > +#include <dt-bindings/gpio/gpio.h> > > +#include <dt-bindings/sound/fsl-imx-audmux.h> > > + > > +/ { > > + model = "Variscite VAR-SOM-MX6 module"; > > + compatible = "variscite,var-som-imx6q", "fsl,imx6q"; > > + > > + chosen { > > + stdout-path = &uart1; > > + }; > > + > > + memory@10000000 { > > + device_type = "memory"; > > + reg = <0x10000000 0x40000000>; > > + }; > > + > > + reg_3p3v: regulator-3p3v { > > + compatible = "regulator-fixed"; > > + regulator-name = "3P3V"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + }; > > + > > + reg_3v3_touch: reg-3v3-touch { > > The prefix is still different than all others. You used "regulator" in > other places, but here it is "reg". Keep your code consistent. Ok, I'll change it to this when I send my v7: reg_3v3_touch: regulator-3v3-touch > > > + compatible = "regulator-fixed"; > > + regulator-name = "touch_3v3_supply"; > > + regulator-always-on; > > Also, missing constraints. Hmm, what's the correct way to determine the constraint values? I'm guessing they should just be set to this based on the name?: regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; > > > Best regards, > Krzysztof >
