Hi Rob, On Thu, Jul 20, 2023 at 10:47 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > On Thu, 20 Jul 2023 21:51:19 +0800, Eric Lin wrote: > > This add YAML DT binding documentation for SiFive Private L2 > > cache controller > > > > Signed-off-by: Eric Lin <eric.lin@xxxxxxxxxx> > > Reviewed-by: Zong Li <zong.li@xxxxxxxxxx> > > Reviewed-by: Nick Hu <nick.hu@xxxxxxxxxx> > > --- > > .../bindings/cache/sifive,pl2cache.yaml | 62 +++++++++++++++++++ > > 1 file changed, 62 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/cache/sifive,pl2cache.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cache/sifive,ccache0.example.dtb: cache-controller@2010000: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cache/sifive,ccache0.example.dtb: cache-controller@2010000: 'interrupts', 'memory-region' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.example.dtb: l2-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l2-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l2-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l2-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l2-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l2-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l2-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l2-cache: 'l3-cache' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l3-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l3-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l3-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l3-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l3-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dtb: l3-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'l3-cache' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l3-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l3-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l3-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l3-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l3-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l3-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible:0: 'sifive,pl2cache1' was expected > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: compatible: ['cache'] is too short > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-block-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-sets' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'cache-size' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dtb: l2-cache: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/cache/sifive,pl2cache.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230720135125.21240-2-eric.lin@xxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Sorry for the errors. I forgot to run `make dt_binding_check`. I'll fix it in the next version. Thanks for the review. Best regards, Eric Lin
