Hey Andrea, On Thu, Jul 20, 2023 at 05:40:02PM +0200, Andrea Collamati wrote: > Add documentation for MCP4728 > > Signed-off-by: Andrea Collamati <andrea.collamati@xxxxxxxxx> > --- > .../bindings/iio/dac/microchip,mcp4728.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml > > diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml > new file mode 100644 > index 000000000000..6fd9be076245 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/microchip,mcp4728.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip MCP4728 DAC > + > +description: > + MCP4728 is a quad channel, 12-bit voltage output > + Digital-to-Analog Converter with non-volatile > + memory and I2C compatible Serial Interface. > + https://www.microchip.com/en-us/product/mcp4728 > + > +maintainers: > + - Andrea Collamati <andrea.collamati@xxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - microchip,mcp4728 This can just be compatible: const: microchip,mcp47288 since you only have a single item in your enum. Otherwise, this looks good to me. Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Despite the email address, I have no knowledge of the hardware in question, I'm just reviewing the binding. Thanks, Conor. > + reg: > + maxItems: 1 > + > + vdd-supply: > + description: | > + Provides both power and acts as the reference supply on the MCP4728 > + when Internal Vref is not selected. > + > +required: > + - compatible > + - reg > + - vdd-supply > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mcp4728@60 { > + compatible = "microchip,mcp4728"; > + reg = <0x60>; > + vdd-supply = <&vdac_vdd>; > + }; > + }; > -- > 2.34.1 >
Attachment:
signature.asc
Description: PGP signature
