On 2023/7/20 6:29, Rob Herring wrote: > On Wed, Jul 19, 2023 at 06:20:53PM +0800, Minda Chen wrote: >> Add PLDA XpressRICH host controller dt-bindings. Both Microchip >> PolarFire SoC and StarFive JH7110 SoC are using PLDA XpressRICH >> PCIe host controller IP. >> >> Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx> >> Reviewed-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> >> --- >> .../pci/plda,xpressrich-pcie-host.yaml | 66 +++++++++++++++++++ >> 1 file changed, 66 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-host.yaml >> >> diff --git a/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-host.yaml b/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-host.yaml >> new file mode 100644 >> index 000000000000..10a10862a078 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-host.yaml >> @@ -0,0 +1,66 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pci/plda,xpressrich-pcie-host.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: PLDA XpressRICH PCIe host controller >> + >> +maintainers: >> + - Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx> >> + - Minda Chen <minda.chen@xxxxxxxxxxxxxxxx> >> + >> +allOf: >> + - $ref: /schemas/pci/pci-bus.yaml# >> + - $ref: plda,xpressrich-pcie-common.yaml# >> + - $ref: /schemas/interrupt-controller/msi-controller.yaml# >> + >> +properties: >> + compatible: >> + const: plda,xpressrich-pcie-host > > What h/w is this in? I don't see why this is needed. You have the common > schema for the IP block and then the Microchip and Starfive schemas for > the 2 implementations. > > Rob OK. I will delete this patch and pcie-plda-plat.c
