On 20/07/2023 00:41, James Hilliard wrote: > This patch adds support for the Variscite MX6 SoM Carrier Board. > > This Carrier-Board has the following : > - LVDS interface for the VLCD-CAP-GLD-LVDS 7" LCD 800 x 480 touch display > - HDMI Connector > - USB Host + USB OTG Connector > - 10/100/1000 Mbps Ethernet > - miniPCI-Express slot > - SD Card connector > - Audio Headphone/Line In jack connectors > - S-ATA > - On-board DMIC > - RS485 Header > - CAN bus header > - SPI header > - Camera Interfaces header > - OnBoard RTC with Coin Backup battery socket > - RS232 Debug Header (IDC10) > - RS232 DTE > > Product Page : https://www.variscite.com/product/single-board-computers/var-mx6customboard > > The dts file based on the ones provided by Variscite on their own > kernel, but adapted for mainline. > > Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> > Signed-off-by: James Hilliard <james.hilliard1@xxxxxxxxx> > --- > .../devicetree/bindings/arm/fsl.yaml | 1 + Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > arch/arm/boot/dts/Makefile | 1 + > .../arm/boot/dts/imx6q-var-mx6customboard.dts | 279 ++++++++++++++++++ > 3 files changed, 281 insertions(+) > create mode 100644 arch/arm/boot/dts/imx6q-var-mx6customboard.dts > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 15d411084065..0f583852de8a 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -298,6 +298,7 @@ properties: > - udoo,imx6q-udoo # Udoo i.MX6 Quad Board > - uniwest,imx6q-evi # Uniwest Evi > - variscite,dt6customboard > + - variscite,mx6customboard > - wand,imx6q-wandboard # Wandboard i.MX6 Quad Board > - ysoft,imx6q-yapp4-crux # i.MX6 Quad Y Soft IOTA Crux board > - ysoft,imx6q-yapp4-pegasus # i.MX6 Quad Y Soft IOTA Pegasus board > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 59829fc90315..9cfc3d3e91ea 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -665,6 +665,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ > imx6q-udoo.dtb \ > imx6q-utilite-pro.dtb \ > imx6q-var-dt6customboard.dtb \ > + imx6q-var-mx6customboard.dtb \ > imx6q-vicut1.dtb \ > imx6q-wandboard.dtb \ > imx6q-wandboard-revb1.dtb \ > diff --git a/arch/arm/boot/dts/imx6q-var-mx6customboard.dts b/arch/arm/boot/dts/imx6q-var-mx6customboard.dts > new file mode 100644 > index 000000000000..66047dff11ec > --- /dev/null > +++ b/arch/arm/boot/dts/imx6q-var-mx6customboard.dts > @@ -0,0 +1,279 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Support for Variscite MX6 Carrier-board > + * > + * Copyright 2016 Variscite, Ltd. All Rights Reserved > + * Copyright 2022 Bootlin > + */ > + > +/dts-v1/; > + > +#include "imx6qdl-var-som.dtsi" > +#include <dt-bindings/pwm/pwm.h> > + > +/ { > + model = "Variscite i.MX6 QUAD/DUAL VAR-SOM-MX6 Custom Board"; > + compatible = "variscite,mx6customboard", "fsl,imx6q"; Where is the SoM compatible? Best regards, Krzysztof
