On 18/07/2023 16:30, Michal Simek wrote: >>> >>> Please correct me if I am wrong. Description about ID should be removed from >>> commit message because it is not necessary. And >>> include/dt-bindings/reset/xlnx-versal-net-resets.h >>> should be added when we merge also DT for versal-net SOC. >> >> No, the binding header is needed only if driver is using it. Adding DTS >> will not change that - still no kernel driver users. No benefits of such >> binding. If there are no users and no benefits - don't make it a binding. > > But header in board folder should be fine like these. > arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h > arch/arm64/boot/dts/mediatek/mt8516-pinfunc.h > arch/arm64/boot/dts/mediatek/mt8167-pinfunc.h > arch/arm64/boot/dts/mediatek/mt8173-pinfunc.h > arch/arm64/boot/dts/exynos/exynos-pinctrl.h > arch/arm64/boot/dts/freescale/imx8mq-pinfunc.h > arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h > arch/arm64/boot/dts/freescale/imx8mn-pinfunc.h > arch/arm64/boot/dts/freescale/imx93-pinfunc.h > arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h > arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h > arch/arm64/boot/dts/tesla/fsd-pinctrl.h Yes. If you want to store some constants (register values, firmware magic numbers) and use in DTS, this is the way to go. Most (or all) of examples above are for register values. Best regards, Krzysztof
