On 18/07/2023 17:22, Matthew Croughan wrote: > Mango Pi MQ Quad is a H616 based SBC, add basic support for the board > and its peripherals > > Signed-off-by: Matthew Croughan <matthew.croughan@xxxxxxx> > --- > V1 -> V2: Alphabetical ordering, added "widora,mangopi-mq-quad" compatible > V2 -> V3: Added Signed-off-by, add to device-tree compatible/bindings documentation Thank you for your patch. There is something to discuss/improve. > > .../devicetree/bindings/arm/sunxi.yaml | 5 + As checkpatch tells you - this must be a separate patch. > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../allwinner/sun50i-h616-mangopi-mq-quad.dts | 183 ++++++++++++++++++ > 3 files changed, 189 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-mangopi-mq-quad.dts > Best regards, Krzysztof
