Re: [PATCH v2 14/15] ASoC: dt-bindings: renesas,rsnd.yaml: add common port-def

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob

Thank you for reviewing


> > diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > index 8a821dec9526..d9808b130e8d 100644
> > --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > @@ -9,6 +9,20 @@ title: Renesas R-Car Sound Driver
> >  maintainers:
> >    - Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> >  
> > +definitions:
> 
> $defs

Hmm... many drivers are using "definitions" ?
This kind of indication is very confusable...

> >    port:
> > -    $ref: audio-graph-port.yaml#/definitions/port-base
> > -    unevaluatedProperties: false
> > -    patternProperties:
> > -      "^endpoint(@[0-9a-f]+)?":
> > -        $ref: audio-graph-port.yaml#/definitions/endpoint-base
> > -        properties:
> > -          playback:
> > -            $ref: /schemas/types.yaml#/definitions/phandle-array
> > -          capture:
> > -            $ref: /schemas/types.yaml#/definitions/phandle-array
> > -        unevaluatedProperties: false
> > +    $ref: "#/definitions/port-def"
> 
> It would be better if users just always used "ports { port {}; };" even 
> in the single port case.

"ports" support is added, we can't modify past.



Thank you for your help !!

Best regards
---
Kuninori Morimoto



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux