On 03/07/2023 10:14, Matt Johnston wrote: > On Mon, 2023-07-03 at 09:15 +0200, Krzysztof Kozlowski wrote: >> On Mon, 3 Jul 2023 at 07:31, Matt Johnston <matt@xxxxxxxxxxxxxxxxxxxx> wrote: >>> >>> This property is used to describe a I3C bus with attached MCTP I3C >>> target devices. >>> >>> Signed-off-by: Matt Johnston <matt@xxxxxxxxxxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/i3c/i3c.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml >>> index fdb4212149e7..08731e2484f2 100644 >>> --- a/Documentation/devicetree/bindings/i3c/i3c.yaml >>> +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml >>> @@ -55,6 +55,10 @@ properties: >>> >>> May not be supported by all controllers. >>> >>> + mctp-controller: >>> + description: | >>> + Indicates that this bus hosts MCTP-over-I3C target devices. >> >> I have doubts you actually tested it - there is no type/ref. Also, >> your description is a bit different than existing from dtschema. Why? >> Aren't these the same things? > > (sorry my reply minutes ago was somehow an old draft, please ignore) > > Ah, I'll add > $ref: /schemas/types.yaml#/definitions/flag Although does not matter, but use the same as in dtschema. type: boolean > > Testing with > make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml > I don't see any warnings, and neither after adding mctp-controller to a .dts > (out of tree) and testing with > make CHECK_DTBS=y DT_SCHEMA_FILES=i3c.yaml aspeed-test.dtb > > Should that pick it up? > > For the description, do you mean it differs to the other properties in > i3c.yaml, or something else? It differs than existing mctp-controller property. If this was on purpose, please share a bit more why. If not, maybe use the same description? Best regards, Krzysztof
