Hi Sebastian, On Thu, May 4, 2023 at 7:38 PM Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> wrote: > Split rk808 into a core and an i2c part in preparation for > SPI support. > > Acked-for-MFD-by: Lee Jones <lee@xxxxxxxxxx> > Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> # for RTC > Tested-by: Diederik de Haas <didi.debian@xxxxxxxxx> # Rock64, Quartz64 Model A + B > Tested-by: Vincent Legoll <vincent.legoll@xxxxxxxxx> # Pine64 QuartzPro64 > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> Thanks for your patch, which is now commit c20e8c5b1203af37 ("mfd: rk808: Split into core and i2c") in linus/master stable/master > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1183,12 +1183,17 @@ config MFD_RC5T583 > Additional drivers must be enabled in order to use the > different functionality of the device. > > -config MFD_RK808 > +config MFD_RK8XX > + bool Is there any specific reason why this cannot be modular, like most (all?) of its users that select it? > + select MFD_CORE > + > +config MFD_RK8XX_I2C > tristate "Rockchip RK805/RK808/RK809/RK817/RK818 Power Management Chip" > depends on I2C && OF > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ > + select MFD_RK8XX > help > If you say yes here you get support for the RK805, RK808, RK809, > RK817 and RK818 Power Management chips. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds