On Thu, Jun 29, 2023 at 02:42:39PM +0800, Xingyu Wu wrote: > On 2023/6/29 1:34, Conor Dooley wrote: > > On Wed, Jun 28, 2023 at 02:44:10PM +0800, Xingyu Wu wrote: > >> On 2023/6/14 2:31, Krzysztof Kozlowski wrote: > >> > On 13/06/2023 14:58, Xingyu Wu wrote: > >> >> From: William Qiu <william.qiu@xxxxxxxxxxxxxxxx> > >> >> +allOf: > >> >> + - if: > >> >> + properties: > >> >> + compatible: > >> >> + contains: > >> >> + const: starfive,jh7110-aon-syscon > >> >> + then: > >> >> + required: > >> >> + - "#power-domain-cells" > >> > > >> > Where did you implement the results of the discussion that only some > >> > devices can have power and clock controller? > >> > > >> > According to your code all of above - sys, aon and stg - have clock and > >> > power controllers. If not, then the code is not correct, so please do > >> > not respond with what is where (like you did last time) but actually > >> > implement what you say. > Yeah, following your advice, I modified the codes and there are two options: > > --- a/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml > +++ b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml > @@ -41,6 +41,16 @@ required: > - reg > > allOf: > + - if: > + properties: > + compatible: > + contains: > + const: starfive,jh7110-sys-syscon > + then: > + required: > + - clock-controller > + properties: > + "#power-domain-cells": false > - if: > properties: > compatible: > contains: > const: starfive,jh7110-aon-syscon > then: > required: > - "#power-domain-cells" > + properties: > + clock-controller: false > + - if: > + properties: > + compatible: > + contains: > + const: starfive,jh7110-stg-syscon > + then: > + properties: > + clock-controller: false > + "#power-domain-cells": false > > additionalProperties: false > > Or : > > --- a/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml > +++ b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml > @@ -41,6 +41,17 @@ required: > - reg > > allOf: > + - if: > + properties: > + compatible: > + contains: > + const: starfive,jh7110-sys-syscon > + then: > + required: > + - clock-controller > + else: > + properties: > + clock-controller: false > - if: > properties: > compatible: > contains: > const: starfive,jh7110-aon-syscon > then: > required: > - "#power-domain-cells" > + else: > + properties: > + "#power-domain-cells": false > > additionalProperties: false > > Which one is better? Thanks. This second one looks better to me, as it achieves the same thing in a simpler way. Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
