> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Tuesday, June 27, 2023 2:24 PM > To: Xu Yang <xu.yang_2@xxxxxxx>; peter.chen@xxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > gregkh@xxxxxxxxxxxxxxxxxxx > Cc: conor+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Peng Fan > <peng.fan@xxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Jun Li <jun.li@xxxxxxx> > Subject: Re: [EXT] Re: [PATCH 2/3] dt-bindings: usb: ci-hdrc-usb2: add samsung,picophy-rise-fall-time-adjust property > > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the > message using the 'Report this email' button > > > On 27/06/2023 05:10, Xu Yang wrote: > > Hi Krzysztof, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >> Sent: Monday, June 26, 2023 11:45 PM > >> To: Xu Yang <xu.yang_2@xxxxxxx>; peter.chen@xxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > >> gregkh@xxxxxxxxxxxxxxxxxxx > >> Cc: conor+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Peng > Fan > >> <peng.fan@xxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Jun Li <jun.li@xxxxxxx> > >> Subject: [EXT] Re: [PATCH 2/3] dt-bindings: usb: ci-hdrc-usb2: add samsung,picophy-rise-fall-time-adjust property > >> > >> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report > the > >> message using the 'Report this email' button > >> > >> > >> On 26/06/2023 11:29, Xu Yang wrote: > >>> The samsung,picophy-rise-fall-time-adjust property can help to adjust the > >>> rise/fall times of the high-speed transmitter waveform. The value can be > >>> 0~3. > >>> > >>> Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx> > >>> --- > >>> .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 10 ++++++++++ > >>> 1 file changed, 10 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci- > >> hdrc-usb2.yaml > >>> index 782402800d4a..d84c66c342ac 100644 > >>> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > >>> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > >>> @@ -292,6 +292,16 @@ properties: > >>> minimum: 0x0 > >>> maximum: 0xf > >>> > >>> + samsung,picophy-rise-fall-time-adjust: > >>> + description: > >>> + HS Transmitter Rise/Fall Time Adjustment. Adjust the rise/fall times > >> > >> Adjust with/by what? What are the units? > > > > This property is used to adjust the rise/fall time of the high-speed > > transmitter waveform. It has no unit. According to the description of > > USBNC_n_PHY_CFG1 register, the rise/fall time will be increased or > > decreased by a certain percentage relative to design default time if > > a value is given to this property. > > > > The actions as below: > > - 0: -10% > > - 1: design default > > - 2: +15% > > - 3: +20% > > Include it then in the description or even make the property -percent: Okay, will add this in v2. Thanks, Xu Yang > https://github.com/devicetree-org/dt- > schema%2Fblob%2Fmain%2Fdtschema%2Fschemas%2Fproperty- > units.yaml&data=05%7C01%7Cxu.yang_2%40nxp.com%7C9ba7b99a7b6849ec138e08db76d71211%7C686ea1d3bc2b4c6fa92 > cd99c5c301635%7C0%7C0%7C638234438320292819%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu > MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=j3mETXe6ZMmeDxFbZ3N1hQaIb4wSt3IrIIbxm8f%2F > S1g%3D&reserved=0 > > > Best regards, > Krzysztof
