On Tue, Jun 27, 2023 at 10:12 AM Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote: > > Hi Lucas, > > On 27/06/2023 11:10, Lucas Tanure wrote: > > The new Amlogic T7 SoC does not have a always-on uart, > > so add OF_EARLYCON_DECLARE for it. > > > > Signed-off-by: Lucas Tanure <tanure@xxxxxxxxx> > > --- > > drivers/tty/serial/meson_uart.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > > index 2501db5a7aaf..c24e105a98c5 100644 > > --- a/drivers/tty/serial/meson_uart.c > > +++ b/drivers/tty/serial/meson_uart.c > > @@ -649,6 +649,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt > > > > OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", > > meson_serial_early_console_setup); > > +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", > > + meson_serial_early_console_setup); > > > > #define MESON_SERIAL_CONSOLE (&meson_serial_console) > > #else > > I've reviewed last version of this patch, please keep tags for minor changes, > or explicitely explain why you didn't keep the tag. > > Acked-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> Sure, I didn't keep it because the change from "amlogic,meson-t7-uart" to "amlogic,t7-uart" seem a relevant one. > > Thanks, > Neil