Hi Krzysztof, On Sunday, June 4th, 2023 at 10:43 AM, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 02/06/2023 15:38, Raymond Hackley wrote: > > > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for > > camera flash LEDs. > > > What are the similarities? Same register interface? Same pins? It's not > obvious and your commit should clear explain this. It will be also > justification why you did not make devices compatible. > There is a similar way to control with 2 GPIO pins, strobe and enable, which is not described well in this patch set. Regards, Raymond
