On 02/06/2023 15:38, Raymond Hackley wrote: > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for > camera flash LEDs. What are the similarities? Same register interface? Same pins? It's not obvious and your commit should clear explain this. It will be also justification why you did not make devices compatible. Best regards, Krzysztof