On Wed, Jun 21, 2023 at 10:43:38AM +0200, Krzysztof Kozlowski wrote: > On 20/06/2023 11:32, Varadarajan Narayanan wrote: > > > > >> And then we have... existing bindings qcom,usb-hs-phy.yaml. Don't create > >> something similar with difference in the hyphen. Just use device > >> specific compatible thus device specific filename. > > > > qcom,usb-hs-phy.yaml seems to be for ULPI mode phy and the > > driver we are introducing is for UTMI. We would have to > > modify phy-qcom-usb-hs.c to accomodate M31. Will that be > > acceptable to phy-qcom-usb-hs.c owners/maintainers? > > We don't talk about drivers here but bindings. Why would you need to > modify the driver when introducing new binding for different device? Sorry. I misunderstood your feedback as "use the existing bindings". Will name the bindings file as qcom,ipq5332-usb-hsphy.yaml and post the next version. Thanks Varada
