On Sat, Jun 17, 2023 at 13:55 +0100 Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Fri, 16 Jun 2023 17:10:42 +0200 > Waqar Hameed <waqar.hameed@xxxxxxxx> wrote: > >> Murata IRS-D200 is a PIR sensor for human detection. It uses the I2C bus >> for communication with interrupt support. Add devicetree bindings >> requiring the compatible string, I2C slave address (reg) and interrupts. >> >> Signed-off-by: Waqar Hameed <waqar.hameed@xxxxxxxx> > > This device will have some power supplies, so I'd expect those to be both > listed and marked as required (maybe some are optional?) Right, will add that here (and call `devm_regulator_get_enable()` in driver's probe). [...] >> +required: >> + - compatible >> + - reg >> + - interrupts > > If it is possible to remove interrupts from requires - and hence have > at least a partly functional driver doing basic reading of the sensor > then that is usually a good idea. Far too many board designers seem > to decide that they don't need to wire up interrupt lines. > > If it's really hard then don't worry too much. I see. It would be possible, but would also require some work. Let's leave it for now then?
