Chris Zhong <zyw@xxxxxxxxxxxxxx> writes: [...] > I have test these patches on evb board base on next-20141128 with a > defconfig[0], and with u-boot[1]. > As Doug said, we need below 3 patches for resume. > > 1.https://patchwork.kernel.org/patch/5051881/ - clocksource: > arch_timer: Allow the device tree to specify uninitialized timer > registers > > 2.https://patchwork.kernel.org/patch/5363671/ - clocksource: > arch_timer: Fix code to use physical timers when requested > > 3.https://patchwork.kernel.org/patch/5382141/ - ARM: dts: rk3288: add > arm,cpu-registers-not-fw-configured > > > And it will auto wakeup, as Heiko said in v8. OK, with your series plus those 3 patches on top of next-20141128, I'm now seeing it auto-wakeup, either with multi_v7_defconfig or Heiko's rk3288_defconfig. > But I have never notice before, since the u-boot never enable edp, and > I use the coreboot with edp display. Actually it is a bug in rk3288, > the rk3288 have not 27Mhz clock source, but the edp initially set to > this non-existent clock. At this time, edp is working on a unknown > state, and it always bring a interrupt, this interrupt avoid system > enter suspend. I see, good find! > So if we want to enter suspend normally, the > edp_24m_sel(bit 15) of CRU_CLKSEL28_CON(0xff7600d0) must be set to 1. I didn't try your u-boot fix, but it sounds like there should be a kernel fix for this. Why doesn't the disabling of unused clocks put the EDP into a safe/disabled state? Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
