On 17 June 2023 07:29:06 IST, Binbin Zhou <zhoubb.aaron@xxxxxxxxx> wrote: >On Fri, Jun 16, 2023 at 5:34 PM Conor Dooley <conor.dooley@xxxxxxxxxxxxx> wrote: >> >> On Fri, Jun 16, 2023 at 02:10:38PM +0800, Binbin Zhou wrote: >> > Add the available CPUs in LoongArch binding with DT schema format using >> > json-schema. >> > >> > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx> >> > --- >> > .../devicetree/bindings/loongarch/cpus.yaml | 65 +++++++++++++++++++ >> > 1 file changed, 65 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml >> > >> > diff --git a/Documentation/devicetree/bindings/loongarch/cpus.yaml b/Documentation/devicetree/bindings/loongarch/cpus.yaml >> > new file mode 100644 >> > index 000000000000..c3e2dba42c81 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/loongarch/cpus.yaml >> > @@ -0,0 +1,65 @@ >> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> > +%YAML 1.2 >> > +--- >> > +$id: http://devicetree.org/schemas/loongarch/cpus.yaml# >> > +$schema: http://devicetree.org/meta-schemas/core.yaml# >> > + >> > +title: LoongArch CPUs >> > + >> > +maintainers: >> > + - Binbin Zhou <zhoubinbin@xxxxxxxxxxx> >> > + >> > +description: >> > + The device tree allows to describe the layout of CPUs in a system through >> > + the "cpus" node, which in turn contains a number of subnodes (ie "cpu") >> > + defining properties for every CPU. >> > + >> > +properties: >> > + compatible: >> > + enum: >> > + - loongson,la264 >> > + - loongson,la364 >> > + >> > + reg: >> > + maxItems: 1 >> > + >> > + device_type: true >> > + >> > + clock-frequency: >> > + description: The frequency of cpu in Hz. >> >> Why don't you just add a ref to the common cpu schema and use the >> standard properties for communicating clock frequencies? >> You then get the standard properties for l1 caches, power management, >> frequency scaling etc as a side effect. > >Hi Conor: > >Sorry, not sure if I understand correctly. Do the standard attributes >refer to the following: > >power-domains = <> >clocks = <> >i-cache-size = <> >d-cache-size = <> >next-level-cache = <> Yes, those are the sort of things I meant. Cheers, Conor.
