On 16/06/2023 08:10, Binbin Zhou wrote: > Add the available CPUs in LoongArch binding with DT schema format using > json-schema. > > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx> > --- > .../devicetree/bindings/loongarch/cpus.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml > > diff --git a/Documentation/devicetree/bindings/loongarch/cpus.yaml b/Documentation/devicetree/bindings/loongarch/cpus.yaml > new file mode 100644 > index 000000000000..c3e2dba42c81 > --- /dev/null > +++ b/Documentation/devicetree/bindings/loongarch/cpus.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/loongarch/cpus.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LoongArch CPUs > + > +maintainers: > + - Binbin Zhou <zhoubinbin@xxxxxxxxxxx> > + > +description: > + The device tree allows to describe the layout of CPUs in a system through > + the "cpus" node, which in turn contains a number of subnodes (ie "cpu") > + defining properties for every CPU. I understand you copied it from ARM, but I would prefer to have here something meaningful. Bindings description does not explain what is DTS, but explains what the hardware is. > + > +properties: > + compatible: > + enum: > + - loongson,la264 > + - loongson,la364 > + > + reg: > + maxItems: 1 > + > + device_type: true > + > + clock-frequency: > + description: The frequency of cpu in Hz. > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User-visible cpu name in /proc/cpuinfo. First, aren't you mixing nodes? Second, it is derived from compatible, so no need for such property. > + > +required: > + - compatible > + - reg > + - clock-frequency > + > +additionalProperties: false > + > +examples: > + - | > + cpus { > + #size-cells = <0>; > + #address-cells = <1>; > + > + model = "Loongson-2K1000"; Drop, not related. Best regards, Krzysztof
