On Fri, Jun 16, 2023 at 04:59:21PM +0300, Tomi Valkeinen wrote:
> Separate clkout calculations and register writes into two functions:
> ub953_calc_clkout_params and ub953_write_clkout_regs, and add a struct
> ub953_clkout_data that is used to store the clkout parameters.
...
> +struct ub953_clkout_data {
> + u32 hs_div;
> + u32 m;
> + u32 n;
Please, use struxt u32_fract instead of m/n.
> + unsigned long rate;
> +};
...
> +static void ub953_calc_clkout_params(struct ub953_data *priv,
> + unsigned long target_rate,
> + struct ub953_clkout_data *clkout_data)
> +{
> + struct device *dev = &priv->client->dev;
> + unsigned long clkout_rate;
> + u64 fc_rate;
> +
> + fc_rate = ub953_get_fc_rate(priv);
> +
> + if (priv->hw_data->is_ub971) {
> + u8 m, n;
Ditto. struct u8_fract; (But probably needs to be added into math.h.
I'll Ack/Rb such a patch when one appears.
> + clkout_rate = ub953_calc_clkout_ub971(priv, target_rate,
> + fc_rate, &m, &n);
Can be also parameter to that function.
> + clkout_data->m = m;
> + clkout_data->n = n;
> +
> + dev_dbg(dev, "%s %llu * %u / (8 * %u) = %lu (requested %lu)",
> + __func__, fc_rate, m, n, clkout_rate, target_rate);
> + } else {
> + u8 hs_div, m, n;
Yeah, and so on...
> + clkout_rate = ub953_calc_clkout_ub953(priv, target_rate,
> + fc_rate, &hs_div, &m, &n);
> +
> + clkout_data->hs_div = hs_div;
> + clkout_data->m = m;
> + clkout_data->n = n;
> +
> + dev_dbg(dev, "%s %llu / %u * %u / %u = %lu (requested %lu)",
> + __func__, fc_rate, hs_div, m, n, clkout_rate,
> + target_rate);
> + }
> +
> + clkout_data->rate = clkout_rate;
> +}
--
With Best Regards,
Andy Shevchenko
