On Fri, 16 Jun 2023 at 05:15, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 16/06/2023 05:58, jaswinder.singh@xxxxxxxxxx wrote: > > From: Jassi Brar <jaswinder.singh@xxxxxxxxxx> > > > > Socionext's DeveloperBox is based on the SC2A11B SoC (Synquacer). > > Specify bindings for the platform and boards based on that. > > > > Signed-off-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx> > > --- > > .../bindings/arm/socionext/synquacer.yaml | 28 +++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/socionext/synquacer.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml b/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml > > new file mode 100644 > > index 000000000000..72554a4f1c92 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml > > @@ -0,0 +1,28 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/socionext/synquacer.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Socionext Synquacer platform > > + > > +maintainers: > > + - Masahisa Kojima <masahisa.kojima@xxxxxxxxxx> > > + - Jassi Brar <jaswinder.singh@xxxxxxxxxx> > > + > > +description: > > + Socionext SC2A11B (Synquacer) SoC based boards > > + > > +properties: > > + $nodename: > > + const: '/' > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - socionext,developer-box > > + - const: socionext,synquacer > > Last compatible looks very generic. Too generic. Are you sure it > uniquely identifies one specific SoC (not family, not generation, not > series)? > Yeah it does sound generic, but Synquacer and SC2A11B are interchangeably used in s/w. And the dts in u-boot use this. Kojima-san may have the final opinion. thanks.