Hi Philipp:
On 2014年12月03日 17:19, Philipp Zabel wrote:
Hi Andy,
Am Mittwoch, den 03.12.2014, 08:54 +0800 schrieb Andy Yan:
+Required properities:
+- compatible: platform specific such as:
+ * "fsl,imx6q-hdmi"
+ * "fsl,imx6dl-hdmi"
+ * "rockchip,rk3288-dw-hdmi"
I think we should add a common compatible value "snps,dw-hdmi-tx" here:
compatible = "fsl,imx6q-hdmi", "snps,dw-hdmi-tx";
How about "snps,dw-hdmi", because the driver is not only about
hdmi tx, but also include hdmi phy.
Synopsys call the whole module
"DesignWare HDMI Transmitter (TX) IP Solution":
https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_14_csds_tx
https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_20_csds_tx
That includes the PHY. I'd prefer keeping the -tx in there to
differentiate from a possible future "snps,dw-hdmi-rx":
https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_14_csds_rx
https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_20_csds_rx
Ok, I will add the compatible "snps, dw-hdmi-tx",
So do I need to add this value to imx6dl.dtsi?
If we add such compatible value, do we have to implement another
platform driver like dw_hdmi-pltfm.c with the
compatible="snps,dw-hdmi" ,
or just include the compatible value in dw_hdmi-imx.c and
dw_hdmi-rockchip.c?
That common compatible doesn't have to be used by any driver. It's just
there to show these are the same/similar IP core.
If a common driver without any SoC specific knowledge could be written,
that one would match against the common compatible.
regards
Philipp
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
