Re: [PATCH 1/1] ASoC: dt-bindings: tlv320aic32x4: convert to DT schema format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/06/2023 10:15, Alexander Stein wrote:
> Convert the binding to DT schema format.
> Since commit 514b044cba667 ("ASoC: tlv320aic32x4: Model PLL in CCF")
> clocks & clock-names = "mclk" is mandatory, it has been added to required
> properties as well. '#sound-dai-cells' is added for reference from
> simple-audio-card.
> 
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---



> -	aic32x4-gpio-func= <
> -			0xff /* AIC32X4_MFPX_DEFAULT_VALUE */
> -			0xff /* AIC32X4_MFPX_DEFAULT_VALUE */
> -			0x04 /* MFP3 AIC32X4_MFP3_GPIO_ENABLED */
> -			0xff /* AIC32X4_MFPX_DEFAULT_VALUE */
> -			0x08 /* MFP5 AIC32X4_MFP5_GPIO_INPUT */
> -		>;
> -};
> diff --git a/Documentation/devicetree/bindings/sound/tlv320aic32x4.yaml b/Documentation/devicetree/bindings/sound/tlv320aic32x4.yaml
> new file mode 100644
> index 0000000000000..ebf84cdcb68d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/tlv320aic32x4.yaml

Filename based on compatibles, so at least vendor prefix missing.

> @@ -0,0 +1,103 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2019 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/tlv320aic32x4.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TLV320AIC32x4 Stereo Audio codec
> +
> +maintainers:
> +  - Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> +
> +description: |
> +  The TLV320AIC32x4 audio codec can be accessed using I2C or SPI
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tas2505
> +      - ti,tlv320aic32x4
> +      - ti,tlv320aic32x6
> +
> +  reg:
> +    description: |
> +      I2C address or SPI chip select of the device

Drop description. Instead missing maxItems.

> +
> +  clocks:
> +    items:
> +      - description: Master clock
> +
> +  clock-names:
> +    items:
> +      - const: mclk
> +
> +  av-supply:
> +    description: Analog core power supply
> +
> +  dv-supply:
> +    description: Digital core power supply
> +
> +  iov-supply:
> +    description: Digital IO power supply
> +
> +  ldoin-supply:
> +    description: LDO power supply
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: |
> +      GPIO used for hardware reset

Drop description, it's obvious.

> +
> +  '#sound-dai-cells':
> +    const: 0
> +
> +  aic32x4-gpio-func:
> +    description: |
> +       GPIO function configuration for pins MFP1-MFP5.
> +       Types are defined in include/sound/tlv320aic32x4.h
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    minItems: 5
> +    maxItems: 5
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - iov-supply

allOf goes here. Missing ref to dai-common.

> +
> +additionalProperties: false
> +
> +allOf:
> +  - if:
> +      not:
> +        required:
> +          - ldoin-supply
> +    then:
> +      required:
> +        - av-supply
> +        - dv-supply
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      codec: tlv320aic32x4@18 {

Node names should be generic. See also explanation and list of examples
in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +        compatible = "ti,tlv320aic32x4";
> +        reg = <0x18>;
Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux