On 12/06/2023 09:40, zhuyinbo wrote: > > > 在 2023/6/12 下午3:17, Krzysztof Kozlowski 写道: >> On 12/06/2023 09:13, zhuyinbo wrote: >>> >>> >>> 在 2023/6/10 上午12:45, Krzysztof Kozlowski 写道: >>>> On 09/06/2023 05:13, zhuyinbo wrote: >>>>> >>>>> >>>>> 在 2023/6/8 下午9:26, Krzysztof Kozlowski 写道: >>>>>> On 08/06/2023 14:10, zhuyinbo wrote: >>>>>>> >>>>>>> >>>>>>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道: >>>>>>>> On 08/06/2023 13:42, zhuyinbo wrote: >>>>>>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>>>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>>>>>>>> @@ -16,6 +16,7 @@ properties: >>>>>>>>> compatible: >>>>>>>>> enum: >>>>>>>>> - loongson,ls2k1000-spi >>>>>>>>> + - loongson,ls2k0500-spi >>>>>>>> >>>>>>>> Aren't they compatible? >>>>>>>> >>>>>>> >>>>>>> >>>>>>> Are you saying that the spi driver is compatible with 2k0500 ? >>>>>> >>>>>> Didn't you say this through 11 previous revisions? >>>>> >>>>> >>>>> Yes, did I understand your meaning incorrectly ? >>>> >>>> If they are compatible, then they are not part of one enum. They could >>>> not be as this would easily fail in testing of your DTS. >>>> >>> >>> >>> The "loongson,ls2k0500-spi" wasn't a compatible in previous version and >>> I will add "loongson,ls2k0500-spi" as a compatible in spi driver and >>> added it as a part of the one enum in dt-binding. >> >> No, because you claimed - if I understood correctly - that they are >> compatible. Don't add fake entries to the driver. >> > > > I'm a bit confused, and I just need to add 'loongson,ls2k0500-spi' as > one enum in dt-bindings, but driver don't add this entry ? Compatibility is expressed with a list: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#compatible so it cannot be just one enum, but "items". There are hundreds of examples including example-schema. Best regards, Krzysztof
