On 08/06/2023 10:39, zhuyinbo wrote: >>> >>> Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>> --- >>> .../bindings/spi/loongson,ls2k-spi.yaml | 41 +++++++++++++++++++ >>> MAINTAINERS | 6 +++ >>> 2 files changed, 47 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>> new file mode 100644 >>> index 000000000000..423ee851edd5 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >> >> Filename based on compatible. > > > There will be more ls2k series SoC spi device in the future thus I still > use "loongson,ls2k-spi.yaml" for cover it. Add them now. > >> >>> @@ -0,0 +1,41 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/spi/loongson,ls2k-spi.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Loongson SPI controller >>> + >>> +maintainers: >>> + - Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> >>> + >>> +allOf: >>> + - $ref: /schemas/spi/spi-controller.yaml# >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - loongson,ls2k1000-spi >> >> No compatibles for other devices? Didn't we have big discussion about this? >> >> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 > > > There are other ls2k SPI devices compatible, such as, > "loongson,ls2k0500-spi", "loongson,ls2k2000-spi" but currently I plan to > add ls2k1000 spi device first, Other ls2k SoC spi device adaptation may > require some additional work and I will add it later. Previously you claimed this serves entire family, so I don't understand why you need to fix something. Why previously it was working for entire family but now it does not? Best regards, Krzysztof
