> >> Please drop all simple debug success messages. Linux has already > >> infrastructure for this. > >> > > Okay. I will change the print dev_info to dev_dbg about debug message. > > No, drop them. This piece of code had already 2 printks for register contents! > Your driver is overloaded with printks and they are mostly useless for the user. I will drop them to simplify the code. > >> Please drop all simple debug success messages. Linux has already > >> infrastructure for this. > > > > Can I keep log for dev_dbg? > > Of course not. This was dev_dbg and I commented on this. This is not a good > debug, we do not print anything on function entrance and exit. > ftrace() is for this. Well, for debugging purposes, I'm going to have to dig into ftrace. This is a great tip. > >> > >> Are you sure you run checkpatch on this? Error messages on debugfs > >> are almost always incorrect. > > > > Yes, I have run checkpatch for patches. > > Why the message is incorrect? > > Because debugfs failures should not cause any error prints. It's debug, not > important. > > Do you see anywhere error messages? > > Entire debugfs handling code should be silent and even skip all error checking, > as most API is ready for handling previous errors, I think. Thanks, I understand now. Thanks, Stanley
