Hi Krzysztof, > On 08/06/2023 04:18, Stanley Chang[昌育德] wrote: > >> ERROR: modpost: "devm_usb_get_phy_by_phandle" > >> [drivers/power/supply/wm831x_power.ko] undefined! > >>>> ERROR: modpost: "devm_usb_get_phy" > >> [drivers/power/supply/da9150-charger.ko] undefined! > >> > >> Kconfig warnings: (for reference only) > >> WARNING: unmet direct dependencies detected for USB_PHY > >> Depends on [n]: USB_SUPPORT [=n] > >> Selected by [y]: > >> - PHY_RTK_RTD_USB2PHY [=y] > >> > > > > I will add USB_SUUPRT dependency to Kconfig. > > Why? Do you see other phy drivers needing it? Few have it but many don't, so > you should really investigate the root cause, not just add some dependencies. > > Build test your patches locally before sending and investigate the issues. USB_SUPPORT is required. Because I have select Kconfig USB_PHY. Some drivers have used it as follow drivers/phy/ti/Kconfig drivers/phy/amlogic/Kconfig drivers/phy/renesas/Kconfig drivers/phy/rockchip/Kconfig drivers/phy/allwinner/Kconfig Thanks, Stanley
