Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH 3/3] arm64: dts: renesas: rzg2l-smarc: Enable MTU3a
> counter using DT overlay
>
> Hi Biju,
>
> On Mon, Apr 17, 2023 at 11:02 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Enable mtu3 node using dt overlay and disable scif2 node and delete
> > {sd1_mux,sd1_mux_uhs} nodes as the pins are shared with mtu3 external
> > clock input pins and Z phase signal(MTIOC1A).
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/renesas/Makefile | 2 +
> > .../boot/dts/renesas/rzg2l-smarc-pmod.dtso | 43 +++++++++++++++++++
> > 2 files changed, 45 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/renesas/rzg2l-smarc-pmod.dtso
> >
> > diff --git a/arch/arm64/boot/dts/renesas/Makefile
> > b/arch/arm64/boot/dts/renesas/Makefile
> > index f130165577a8..57727bcd1334 100644
> > --- a/arch/arm64/boot/dts/renesas/Makefile
> > +++ b/arch/arm64/boot/dts/renesas/Makefile
> > @@ -81,8 +81,10 @@ dtb-$(CONFIG_ARCH_R9A07G043) +=
> > r9a07g043-smarc-pmod.dtbo
> > dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044c2-smarc.dtb
> > dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc.dtb
> > dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc-cru-csi-ov5645.dtbo
> > +dtb-$(CONFIG_ARCH_R9A07G044) += rzg2l-smarc-pmod.dtbo
> >
> > dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-smarc.dtb
> > +dtb-$(CONFIG_ARCH_R9A07G054) += rzg2l-smarc-pmod.dtbo
> >
> > dtb-$(CONFIG_ARCH_R9A09G011) += r9a09g011-v2mevk2.dtb
> >
> > diff --git a/arch/arm64/boot/dts/renesas/rzg2l-smarc-pmod.dtso
> > b/arch/arm64/boot/dts/renesas/rzg2l-smarc-pmod.dtso
> > new file mode 100644
> > index 000000000000..a502faf6e1ad
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc-pmod.dtso
> > @@ -0,0 +1,43 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Device Tree Source for the RZ/{G2L,V2L} SMARC EVK PMOD parts
> > + *
> > + * Copyright (C) 2023 Renesas Electronics Corp.
> > + */
> > +
> > +/dts-v1/;
> > +/plugin/;
> > +
> > +#include <dt-bindings/pinctrl/rzg2l-pinctrl.h>
> > +
> > +&mtu3 {
> > + pinctrl-0 = <&mtu3_pins>;
> > + pinctrl-names = "default";
> > +
> > + status = "okay";
> > +};
> > +
> > +&pinctrl {
> > + mtu3_pins: mtu3 {
> > + mtu3-zphase-clk {
> > + pinmux = <RZG2L_PORT_PINMUX(19, 0, 3)>; /*
> MTIOC1A */
> > + };
> > +
> > + mtu3-ext-clk-input-pin {
> > + pinmux = <RZG2L_PORT_PINMUX(48, 0, 4)>, /*
> MTCLKA */
> > + <RZG2L_PORT_PINMUX(48, 1, 4)>; /*
> MTCLKB */
> > + };
> > + };
> > +};
> > +
> > +&scif2 {
> > + status = "disabled";
> > +};
> > +
> > +&sdhi1_pins {
> > + /delete-node/ sd1_mux;
> > +};
> > +
> > +&sdhi1_pins_uhs {
> > + /delete-node/ sd1_mux_uhs;
> > +};
>
> I'm afraid deleting nodes in the base DT from an overlay does not work...
It doesn't give any pin conflicts. I will recheck and confirm.
When I tested, it clears the counter, when I remove/insert SD card as the
counter clearing source is P19_0 function3.
What about disabling SDHI1?? As pins shared between MTU3a and SDHI1,
When we use this overlay, we enable only MTU3a and disable SDHI1.
For a normal customer use case, SDHI1 will be always enabled.
But they may use different pins if they use both SDHI1 and MTU3a Z-Phase signal.
Cheers,
Biju
