On 08/06/2023 08:36, Tony Lindgren wrote: > * Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> [230607 18:17]: >> On 05/06/2023 11:52, Tony Lindgren wrote: >>> +title: Pinctrl driver for hardware with a single register for one or more pins >> >> I asked to drop the driver references but it is still here. Bindings are >> not describing drivers. >> >> "Generic Pin Controller with a Single Register for One or More Pins" > > Oh right it's supposed to describe hardware, will update thanks. > >>> +patternProperties: >>> + '-pins$|-pin': >> >> you did not implement my comments fully, probably we misunderstood each >> other. Why do you allow anything after '-pin'? Let's make it pure suffix >> for both cases: '-pins?$' > > I'll check what kind of node renaming that would cause. At least TI > arm64 SoCs use naming like -pins-default and -pins-wakeup. Is your > preference to rename all those nodes to -default-pins and -wakeup-pins? No, pattern matching TI SoC is fine, but your current also doesn't. Or rather - matches by mistake. You do not allow anything after -pins. Best regards, Krzysztof
