On 07.06.2023 18:07, Krzysztof Kozlowski wrote: > On 07/06/2023 16:55, Arseniy Krasnov wrote: >>>>> The bindings and your driver internal representation are two different >>>>> things. Anyway, as mentioned above, wiring the RB line to one die and >>>>> not the other would be valid hardware design and would require the rb >>>>> property to be in the chip node. Please perform a per-chip property read >>>>> in the driver as well. >>>> >>>> Done, I resend both patches (bindings + driver update) as a single patchset. Your review comments >>>> for driver code were also fixed. >>> >>> No, please send new version, not the same. New version means with fixed >>> comments and with patch changelog. >> >> Sorry, Yes, I mean new version, here it is: >> https://lore.kernel.org/linux-mtd/20230607145026.2899547-1-AVKrasnov@xxxxxxxxxxxxxx/ >> >> There I fixed bindings and tested it. > > I still see v1 and there is no changelog. So it's the same? No, v1 is for new patchset from the link above. Both patches (bindings and driver) are updated there. I attached changelog here as reply for cover letter of the patchset: https://lore.kernel.org/linux-mtd/a1e048aa-ec64-bd0b-aa17-e3e9bdf18090@xxxxxxxxxxxxxx/ Thanks, Arseniy > > Best regards, > Krzysztof >
