On 07/06/2023 08:11, Hsiao Chien Sung wrote: > Add reset control bits for MT8188 VDOSYS1. Double space -> one space. > > Signed-off-by: Hsiao Chien Sung <shawn.sung@xxxxxxxxxxxx> > --- > include/dt-bindings/reset/mt8188-resets.h | 12 ++++++++++++ This should be squashed with patch adding compatible. > 1 file changed, 12 insertions(+) > > diff --git a/include/dt-bindings/reset/mt8188-resets.h b/include/dt-bindings/reset/mt8188-resets.h > index 377cdfda82a9..439a9a25ca19 100644 > --- a/include/dt-bindings/reset/mt8188-resets.h > +++ b/include/dt-bindings/reset/mt8188-resets.h > @@ -33,4 +33,16 @@ > > #define MT8188_TOPRGU_SW_RST_NUM 24 > > +/* VDOSYS1 */ > +#define MT8188_VDO1_RST_MERGE0_DL_ASYNC 9 Indices start from 0. > +#define MT8188_VDO1_RST_MERGE1_DL_ASYNC 10 > +#define MT8188_VDO1_RST_MERGE2_DL_ASYNC 11 > +#define MT8188_VDO1_RST_MERGE3_DL_ASYNC 32 ... and are continuous. Commit explains here nothing that it is for existing reset, so you got such review. Best regards, Krzysztof
