> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Friday, June 2, 2023 9:15 PM > To: Xu Yang <xu.yang_2@xxxxxxx>; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx > Cc: shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx <linux- > imx@xxxxxxx>; linux-phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > usb@xxxxxxxxxxxxxxx; Jun Li <jun.li@xxxxxxx> > Subject: [EXT] Re: [PATCH 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format > > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the > message using the 'Report this email' button > > > Resending as my previous email probably got lost. If you got it twice, > apologies. > > On 01/06/2023 10:07, Xu Yang wrote: > > Convert the binding to DT schema format. > > > > > Thank you for your patch. There is something to discuss/improve. > > > > new file mode 100644 > > index 000000000000..48b0e654e52c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/mxs-usb-phy.yaml > > Filename matching compatibles, so for exmaple fsl,mxs-usbphy.yaml. Okay. > > > @@ -0,0 +1,97 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/phy/mxs- > usb- > phy.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C6226d685ea124535c3fe08db636b6ae9%7C686ea1d3bc2b4c6fa > 92cd99c5c301635%7C0%7C0%7C638213085231814761%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2 > luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=b%2Fw1rubqpTN%2B5JagSotDCTmju%2BMHRsuTs > JzyZ4OALbs%3D&reserved=0 > > +$schema: http://devicetree.org/meta- > schemas%2Fcore.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C6226d685ea124535c3fe08db636b6ae9%7C686ea > 1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638213085231814761%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM > DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LYDKXb56MU2PeLqHdqGnTFQLKs3B > Yha5KTFyYRCPBPY%3D&reserved=0 > > + > > +title: Freescale MXS USB Phy Device > > + > > +maintainers: > > + - Xu Yang <xu.yang_2@xxxxxxx> > > + > > +properties: > > + compatible: > > + oneOf: > > + - enum: > > + - fsl,imx23-usbphy > > + - fsl,vf610-usbphy > > + - items: > > + - enum: > > + - fsl,imx28-usbphy > > + - fsl,imx6ul-usbphy > > + - fsl,imx6sl-usbphy > > + - fsl,imx6sx-usbphy > > + - fsl,imx6q-usbphy > > + - const: fsl,imx23-usbphy > > + - items: > > + - enum: > > + - fsl,imx7ulp-usbphy > > + - fsl,imx6sll-usbphy > > + - const: fsl,imx6ul-usbphy > > + - const: fsl,imx23-usbphy > > + - items: > > + - const: fsl,imx8dxl-usbphy > > + - const: fsl,imx7ulp-usbphy > > + - const: fsl,imx6ul-usbphy > > + - const: fsl,imx23-usbphy > > I cannot find these in the old bindings. Please explain changes to > conversion in commit msg. So far you wrote that it is pure conversion. Will add other message in commit. > > > + > > + reg: > > + minItems: 1 > > + maxItems: 2 > > + > > + interrupts: > > + minItems: 1 > > + maxItems: 2 > > + > > + fsl,anatop: > > + description: > > + phandle for anatop register, it is only for imx6 SoC series > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + maxItems: 1 > > + > > + fsl,tx-cal-45-dn-ohms: > > + description: > > + Resistance (in ohms) of switchable high-speed trimming resistor > > + connected in parallel with the 45 ohm resistor that terminates > > + the DN output signal. > > + minimum: 35 > > + maximum: 54 > > + default: 45 > > + > > + fsl,tx-cal-45-dp-ohms: > > + description: > > + Resistance (in ohms) of switchable high-speed trimming resistor > > + connected in parallel with the 45 ohm resistor that terminates > > + the DP output signal. > > + minimum: 35 > > + maximum: 54 > > + default: 45 > > + > > + fsl,tx-d-cal: > > + description: > > + Current trimming value (as a percentage) of the 17.78 mA TX > > + reference current. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 79 > > + maximum: 119 > > + default: 100 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > missing allOf narrowing anatop to imx6. Also interrupts and reg should > be narrowed to respective variants. Will add such limitation. > > > +unevaluatedProperties: false > > Instead additionalProperties: false. Okay. > > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + > > + usbphy1: usb-phy@20c9000 { > > + compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy"; > > + reg = <0x020c9000 0x1000>; > > + interrupts = <0 44 IRQ_TYPE_LEVEL_HIGH>; > > Is 0 known flag? Use defines for it. Will use defines. > > > + fsl,anatop = <&anatop>; > > + }; > > + > > +... > > Best regards, > Krzysztof Thanks, Xu Yang
