On 24/05/2023 14:35, Claudiu Beznea wrote: > Convert Atmel SAMA5D2 shutdown controller to YAML. SAMA7G5 SHDWC DT node > (available in arch/arm/boot/dts/sama7g5.dtsi) has syscon along with its > compatible. There is no usage of this syscon in the current code but it > may be necessary in future as some registers of SHDWC are accessed in > different drivers (at91-sama5d2_shdwc.c and arch/arm/mach-at91/pm.c). > Thus update the YAML with it to make DT checkers happy. > > +--- > +$id: http://devicetree.org/schemas/power/reset/atmel,sama5d2-shdwc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel SAMA5D2 SHDWC Shutdown Controller > + > +maintainers: > + - Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> > + > +description: > + Atmel SHDWC shutdown controller controls the power supplies VDDIO and VDDCORE > + and the wake-up detection on debounced input lines. > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: microchip,sama7g5-shdwc > + - const: syscon > + - items: These are not items, but just enum. This could not work as intended. > + enum: > + - atmel,sama5d2-shdwc > + - microchip,sam9x60-shdwc > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + debounce-delay-us: > + description: > + Minimum wake-up inputs debouncer period in microseconds. It is usually a > + board-related property. > + > + atmel,wakeup-rtc-timer: > + description: enable real-time clock wake-up > + type: boolean > + > +patternProperties: > + "^input@[0-15]$": > + description: > + Wake-up input nodes. These are usually described in the "board" part of > + the Device Tree. Note also that input 0 is linked to the wake-up pin and > + is frequently used. > + type: object > + properties: > + reg: > + description: contains the wake-up input index > + minimum: 0 > + maximum: 15 > + > + atmel,wakeup-active-high: > + description: > + The corresponding wake-up input described by the child forces the > + wake-up of the core power supply on a high level. The default is to > + be active low. > + type: boolean > + > + required: > + - reg > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - clocks > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - microchip,sam9x60-shdwc > + - microchip,sama7g5-shdwc > + then: > + properties: > + atmel,wakeup-rtt-timer: > + description: enable real-time timer wake-up > + type: boolean Don't define properties in allOf. This should be in top-level. Missing additionalProperties: false. Best regards, Krzysztof
