On 01/06/2023 21:10, Daniel Golle wrote: > On Thu, Jun 01, 2023 at 06:54:01PM +0200, Krzysztof Kozlowski wrote: >> On 31/05/2023 18:10, Daniel Golle wrote: >>> Add pck and mck clocks which are needed to access I2C registers on MT7981. >>> >>> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml >>> index fda0467cdd954..550795f6573c5 100644 >>> --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml >>> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml >>> @@ -78,6 +78,8 @@ properties: >>> - const: dma >>> - const: arb >>> - const: pmic >>> + - const: mck >>> + - const: pck >>> >> >> Adding names does not magically add the clocks. This wasn't tested. > > Adding the clocks is done in patch 2/2 which just wasn't sent to > devicetree@ and dt maintainers, but to the relevant mailing lists > instead. Was that wrong and should I always send the complete series > also to devicetree@ as well as dt maintainers? I didn't mean implementation. I meant that you still do not allow more clocks! You can put into names whatever you wish but clocks are taken from "clocks" property, not from clock-names. Best regards, Krzysztof
